Added filter to short-circuit API calls to Salesforce. Thanks to GitHub user @verygoodplugins for the submission.#512
Merged
jonathanstegall merged 3 commits intoMinnPost:masterfrom Feb 3, 2023
Conversation
Member
|
Thanks for this! There's nothing obvious that looks troubling at all, I just want to have a chance to run it before I merge it, and also add the new hook to the developer hook documentation spots where it belongs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
This PR adds a filter to the
http_request()function in classObject_Sync_Sf_Salesforceto allow short-circuiting the API call and response.The goal of the PR is to help create a tighter integration with WP Fusion (https://github.com/verygoodplugins/wp-fusion-lite/ and https://wpfusion.com/).
The logic follows what already exists in WP core, for example with
update_metadata(): https://github.com/WordPress/WordPress/blob/master/wp-includes/meta.php#L233With this filter in place, we will be able to:
wp_remote_request())We're excited to create a deeper integration between WP Fusion and Object Sync for Salesforce, and this change would allow us to tie the two plugins together much more closely than is currently possible.
Thanks for your consideration :)