Cloud v2 Implementation#199
Merged
4drian3d merged 5 commits intoMiniPlaceholders:mainfrom Jul 24, 2024
Merged
Conversation
NickImpact
suggested changes
Mar 27, 2024
| .apply(commandManager, AudienceProvider.nativeAudience()); | ||
| MinecraftExceptionHandler.create(AudienceProvider.nativeAudience()) | ||
| .defaultHandlers() | ||
| .decorator(component -> Component.text().append(TITLE).appendSpace().append(component).build()); |
There was a problem hiding this comment.
Only thing missed here was registering the exception handler back to the command manager. Should be #registerTo(CommandManager) at the end of the chain there. Might need to play with generics on the create call to let it accept the manager.
4drian3d
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to Cloud v2, though it seems like they only support Sponge API 7 at this time. May need to stall this PR until then