Adds support for a retry count and raising#187
Merged
nikz merged 1 commit intoMindscapeHQ:masterfrom Oct 16, 2024
Merged
Conversation
Adds two new configuration settings:
* Configure how many times raygun4ruby should retry sending the error
to the Raygun servers using `error_report_max_attempts` (defaults
to 1)
* Configure whether or not raygun4ruby should re-raise an exception if
the send fails using `raise_on_failed_error_report` (defaults to
false)
TheRealAgentK
approved these changes
Sep 20, 2024
TheRealAgentK
left a comment
There was a problem hiding this comment.
LGTM - is there maybe a point in documenting this new configuration somewhere?
Ah, just saw that in Readme you link to the actual configuration ruby file. Okis then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new configuration settings:
error_report_max_attempts(defaults to 1)raise_on_failed_error_report(defaults to false)