Unwraps Sidekiq::JobRetry::Handled errors#185
Merged
nikz merged 2 commits intoMindscapeHQ:masterfrom Jul 28, 2024
Merged
Conversation
This means the inner exception is reported to Raygun, with a tag `sidekiq_retry` of "true". Also adds a config setting to disable this behaviour and reporting of retried Sidekiq jobs (`config.track_retried_sidekiq_jobs` defaults to true)
TheRealAgentK
previously approved these changes
Jul 24, 2024
TheRealAgentK
left a comment
There was a problem hiding this comment.
I think the change in itself looks good to me.
miquelbeltran
approved these changes
Jul 24, 2024
miquelbeltran
left a comment
There was a problem hiding this comment.
Change looks good as well. Left a question regarding the default setting.
| send_in_background: false, | ||
| error_report_send_timeout: 10 | ||
| error_report_send_timeout: 10, | ||
| track_retried_sidekiq_jobs: true |
There was a problem hiding this comment.
Is true a good default value for this? I am not sure how annoying it is to have retries reported, but it is good that it can be disabled if required.
Contributor
Author
There was a problem hiding this comment.
I think so - rationale being it's better to log more errors initially and then turn off any that are noisy rather than silently swallow them
sumitramanga
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means the inner exception is reported to Raygun, with a tag
sidekiq_retryof "true".Also adds a config setting to disable this behaviour and reporting of retried Sidekiq jobs (
config.track_retried_sidekiq_jobsdefaults to true)