Improve failsafe exception retrying & large breadcrumb support#147
Merged
Improve failsafe exception retrying & large breadcrumb support#147
Conversation
This calculates a rough size of the Breadcrumb, message length + 100. Assuming all the other fields roughly come out to 100 characters on average. The primary failing of this is that the metadata could be much larger, but calculating the size of the metadata could be costly. This handles the usecase needed by Vydia
Fixes #145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending an exception causes an exception, clear the breadcrumbs store before trying to send the failure exception. This is partially because sending a giant exception payload causes an exception which could be caused by breadcrumbs (this is mitigated with the second change however) and because something in the breadcrumbs could be causing the problem.
The primary mitigation to the error that occurs during sending a very large payload is to only send the most recent breadcrumbs up to a size limit of 100KB which should address this problem without having to lose all the breadcrumbs.
This change is