Javascript Error Tracking#134
Javascript Error Tracking#134MikeRogers0 wants to merge 23 commits intoMindscapeHQ:masterfrom MikeRogers0:feature/js-error-tracking
Conversation
… what I've done so far
|
Thanks for this Mike. I'll take a look when I get time, either this week or the next. |
|
@UberMouse Thank you for reviewing :) It's a big change, so take your time & enjoy it. |
UberMouse
left a comment
There was a problem hiding this comment.
Sorry for the lengthy delay in getting around to this @MikeRogers0! It's looking good, just a few changes I would like around the tests and to include the user/version information.
|
Awesome thank you for the review, I'll aim to get on it possibly next weekend :) |
|
Eak my weekend got away from me a bit - don't worry, I've not forgotten about this :) |
|
Thanks for your patience @UberMouse 👍 I got a bit of time this evening to do the updated you requested (and respond to the other comments). Any other changes (I might have some time over NYE)? |
UberMouse
left a comment
There was a problem hiding this comment.
Looking good :) just a few changes
lib/raygun/javascript_tracker.rb
Outdated
| end | ||
|
|
||
| def js_api_version | ||
| @js_api_version ||= Raygun.configuration.js_api_version || '1.14.0' |
There was a problem hiding this comment.
This should default to '' so that it always falls back to the latest version unless you specifically set it to another version. The url should be fine if it ends up like //cdn.raygun.io/raygun4js//raygun.min.js
|
Thanks for that Mike. I tested it and that URL format with double slashes in it doesn't work on S3 so I've just gone ahead and fixed that part up since it was my suggestion. I've opened a new PR and will merge that work in shortly over there. |
This adds the
js_api_keyconfiguration option, if it's present it'll inject the JS code to a HTML page.Some key changes:
specstospecto be more inline with other projects I've worked on.expect( something ).to eq( something else )as it's closer to their sample docs.This is for the issue #132