Timeout network request to send crash reports to API#129
Merged
Conversation
Unfortunately this just triggers a timeout, doesn't actually confirm it will time out. But confirms that the behaviour when a time out _does_ happen is correct
Noticed while running unit tests that this was passed a proc once which caused a failure. Under the assumption that being passed a proc means something went wrong, make that a failure case here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configuration option for setting the timeout of the POST call to the API server when submitting a crash report.
This is primarily to ensure that when using the send_in_background configuration option that network issues don't cause a bunch of observables to stick around waiting for the network call to finish clogging up memory and threads.
Also bumps rake from v0.9.6 to v11 and replaces Fakeweb with webmock
This change is