Skip to content

Retrieve subscribed topics#43

Merged
MihaelIsaev merged 1 commit intoMihaelIsaev:masterfrom
chinh-tran:feature/get-topics
Mar 14, 2024
Merged

Retrieve subscribed topics#43
MihaelIsaev merged 1 commit intoMihaelIsaev:masterfrom
chinh-tran:feature/get-topics

Conversation

@chinh-tran
Copy link
Copy Markdown
Contributor

Retrieves the subscribed topics for a given token as documented here:
https://developers.google.com/instance-id/reference/server?hl=en#get_information_about_app_instances

@MihaelIsaev
Copy link
Copy Markdown
Owner

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16

I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

@chinh-tran
Copy link
Copy Markdown
Contributor Author

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16 I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

@MihaelIsaev Thanks for the feedback! I've updated the code.

@MihaelIsaev MihaelIsaev merged commit f84d48a into MihaelIsaev:master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants