fixed decode token issue#27
Merged
MihaelIsaev merged 3 commits intoMihaelIsaev:masterfrom Sep 15, 2020
Merged
Conversation
fix token decode issue
MihaelIsaev
requested changes
Sep 15, 2020
MihaelIsaev
approved these changes
Sep 15, 2020
Owner
MihaelIsaev
left a comment
There was a problem hiding this comment.
Thank you for the investigation and fix
Owner
|
Thank you! It is available in 2.8.1 now 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
I found strange issue, with used
res.content.decode(Result.self)access_token was not decoded (at the same time JSON body with access_token received) and in total it was impossible to send FCM message.So, I replaced this call to decode access_token using JSON decoder and everything works well.