Make config datamodel equatable and rename FCMApnsAlertOrString helpers#15
Merged
MihaelIsaev merged 3 commits intoMihaelIsaev:masterfrom Nov 29, 2019
Conversation
MihaelIsaev
reviewed
Nov 28, 2019
MihaelIsaev
reviewed
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, it's me again 😬
Should be the last PR I need for now. 🤞
This one make the payload data models
Equatable, again to ease tests. To do this, I had to convert some models fromclasstostruct(FCMApnsPayloadandFCMApnsApsObject).Is there a particular reason for using
classhere or it is simply a default choice?I also renamed the
FCMApnsAlertOrStringtoasPayload/asMessageas mentioned in the previous one.Again, thanks very much for your quick reviews.