Concept: Features / Default features / add default features section to troubleshooting guide#255
Merged
vicroms merged 9 commits intoMicrosoftDocs:mainfrom Feb 27, 2024
Merged
Conversation
Contributor
|
Learn Build status updates of commit 25c6d5b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
dg0yt
reviewed
Feb 2, 2024
dg0yt
reviewed
Feb 2, 2024
|
|
||
| ### Resolution | ||
|
|
||
| To ensure that transitive dependencies like `X` are installed without their default features, you need to promote them to direct dependencies in your top-level manifest and explicitly disable their default features. Modify your `vcpkg.json` to include `X` directly with `"default-features": false`: |
Contributor
There was a problem hiding this comment.
This instruction doesn't lead to the desired resolution when the user needs third port Z which depends on X but lacks the "default-features": false property on the X dependency just because Z's maintainers weren't aware of the default features (at that time).
- The user can't override the behavior.
- The user will face difficulties to realize that this is a port bug in
Z. - The
Zmaintainers have no tool support to check which dependencies have default features - The
Zmaintainers have no way to express that they really want to depend on default-features.
All up to brainware.
Contributor
|
I agree with @dg0yt s comments: You basically have to remember which ports do have default features. Considering that this may change over time, it's almost impossible to avoid the kind of bug @dg0yt describes. Given that default features often lead to much more ports being built, I think this feature should be refined or entirely removed. |
Thomas1664
reviewed
Feb 2, 2024
vicroms
previously requested changes
Feb 8, 2024
Collaborator
|
See #264 for existing documentation that should be included in a standalone features article. |
Contributor
|
Learn Build status updates of commit c099112: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Contributor
|
Learn Build status updates of commit 8aecb9f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Contributor
|
Learn Build status updates of commit bb15527: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
Contributor
|
Learn Build status updates of commit c3a636f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
vicroms
previously requested changes
Feb 22, 2024
Contributor
|
Learn Build status updates of commit 6001874: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
vicroms
previously requested changes
Feb 26, 2024
Contributor
|
Learn Build status updates of commit adc02c6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
PRMerger Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.