Fix both lists of "Supported .NET Framework Libraries" (re: SQLCLR) #4638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: 1) System.Deployment.dll (added in SP1 for SQL Server 2005) 2) System.Core.dll (added in SQL Server 2008) 3) System.Xml.Linq.dll (added in SQL Server 2008) These were already listed in the "Supported Libraries" section of the [Supported .NET Framework Libraries](https://docs.microsoft.com/en-us/sql/relational-databases/clr-integration/database-objects/supported-net-framework-libraries#supported-libraries) documentation page. Rearranged list of assemblies to be in their proper (expected) order.
1) Moved **System.Core** to the proper/expected position. 2) Removed ".dll" extension from **System.Core** and **System.Xml.Linq** to match the rest of the list. 3) Removed extraneous newline between each library that made the list harder to read as you had to scroll to see all of the items. 4) Added HTML comment below the "Supported Libraries" list indicated the other page containing the same list (and that hasn't been updated since SQL Server 2005 went RTM) so that hopefully it will be easier to maintain consistency across future updates.
Contributor
|
@srutzky : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Collaborator
|
@srutzky This is really great work. Thank you! #sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4614
On the Designing Assemblies page:
On the Supported .NET Framework Libraries page:
Take care,
Solomon...
https://SqlQuantumLift.com/
https://SqlQuantumLeap.com/
https://SQLsharp.com/