-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve "See also" sections for string functions #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
craigg-msft
merged 40 commits into
MicrosoftDocs:live
from
srutzky:SRutzky-ImproveSeeAlso
Jan 17, 2018
Merged
Improve "See also" sections for string functions #346
craigg-msft
merged 40 commits into
MicrosoftDocs:live
from
srutzky:SRutzky-ImproveSeeAlso
Jan 17, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a valid aggregate function as the two tests below show: it works in a HAVING clause, and it ignores NULLs. SELECT tmp.[ID], STRING_AGG(tmp.[name], '~') FROM (VALUES (1, 'a'), (2, 'gg'), (1, 'b'), (2, 'hh'), (3, 'zzz')) tmp (ID, [name]) GROUP BY tmp.[ID] HAVING STRING_AGG(tmp.[name], '~') = 'hh~gg'; -- 2 hh~gg SELECT tmp.[ID], STRING_AGG(tmp.[name], '~') FROM (VALUES (1, 'a'), (2, 'zzz'), (1, 'b'), (2, NULL), (2, 'gg')) tmp (ID, [name]) GROUP BY tmp.[ID]; -- 1 b~a -- 2 gg~zzz
Contributor
|
@srutzky : Thanks for your contribution to the SQL documentation! The author, @edmacauley, has been notified to review your proposed change. |
Contributor
|
Thanks for these changes, @srutzky #sign-off |
Contributor
|
Only the author, @edmaca, can sign off on this pull request. |
Contributor
|
@craigg-msft can you merge? |
Contributor
|
Thank you @srutzky and @edmacauley |
Contributor
Author
|
@edmacauley and @craigg-msft : you are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added relevant function links to See also sections. "Relevant" is based on a general operation, such as: converting the value between types, modifying the contents of the string, taking sections of the string, finding something within the string, generating strings, determine a character value or create a character from a value, etc. The idea is to increase the chances that people can find something helpful that they might not have known the name of.
As much as possible made See also sections consistent with actual functions listed first, then generic function list pages, etc after.
Changed link title encoding where necessary to be consistent such that
(and)are HTML-encoded as(and), respectively (instead of as just parenthesis).Added
STRING_AGGto Aggregate Functions page (new as of SQL Server 2017). It is a valid aggregate function and behaves consistently with the definition on that page as the two tests below show: a) it works in aHAVINGclause, and b) it ignoresNULLs.returns:
And:
returns: