Fix "Search Condition" note about code page conversions #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
Thank you @srutzky @edmacauley please review. |
Contributor
|
Makes sense to me, thanks @srutzky for another edit |
Contributor
|
#sign-off |
Contributor
|
Only the author, @rickbyh, can sign off on this pull request. |
Contributor
|
@craigg-msft will need to merge this probably |
Contributor
|
Thank you @srutzky and @edmacauley |
Contributor
Author
|
@edmacauley and @craigg-msft : you are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current note regarding code page conversions with respect to non-Unicode expressions is incorrect in several ways. The new wording is a little longer, but accurate.
Please see the following two posts for a detailed explanation (with examples) of why this change is being made: