Skip to content

Conversation

@srutzky
Copy link
Contributor

@srutzky srutzky commented Sep 10, 2019

Fixes #2827

The behavior changed starting in SQL Server 2016. Please see my comments in #2827 for the test code.

Please check the include reference. The CREATE TABLE page ( https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/t-sql/statements/create-table-transact-sql.md ) uses [!INCLUDE[ssSQL15](../../includes/sssql15-md.md)] but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, sssql16, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.

Take care,
Solomon...
https://SqlQuantumLeap.com/

Fixes #2827 

The behavior changed starting in SQL Server 2016. Please see my comments in #2827 for the test code.

Please check the include. The `CREATE TABLE` page uses  `[!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]` but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, **sssql16**, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.
Additional testing (in another comment in #2827 ) clarified setting the `FLOAT` value via scientific notation vs decimal notation.
Same change as made on "float and real" page.

Fixes MicrosoftDocs#2827 

The behavior changed starting in SQL Server 2016. Please see my comments in MicrosoftDocs#2827 for the test code.

Please check the include. The `CREATE TABLE` page uses  `[!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]` but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, **sssql16**, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.
@PRMerger8
Copy link
Contributor

@srutzky : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Sep 10, 2019
@MikeRayMSFT
Copy link
Contributor

Hi @srutzky - thank you for submitting this, I'm getting your PR reviewed.

For the include files, we're now referring to version number instead of version name. SQL Server 2019 is SQL Server version 15, so the include file is named [!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]. Of course we acknowledge that this is a change from previous releases and file names.

@MikeRayMSFT MikeRayMSFT reopened this Sep 26, 2019
@pmasl
Copy link
Contributor

pmasl commented Sep 26, 2019

#sign-off

@PRMerger16
Copy link
Contributor

@pmasl: I'm sorry - only the author of this article, @MikeRayMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@MikeRayMSFT
Copy link
Contributor

#sign-off

@jborsecnik jborsecnik merged commit 07b71ae into MicrosoftDocs:live Sep 26, 2019
@srutzky
Copy link
Contributor Author

srutzky commented Sep 27, 2019

Hi @MikeRayMSFT

Hi @srutzky - thank you for submitting this, I'm getting your PR reviewed.

You are welcome.

For the include files, we're now referring to version number instead of version name. SQL Server 2019 is SQL Server version 15, so the include file is named [!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]. Of course we acknowledge that this is a change from previous releases and file names.

Not sure if you understood what I was saying. Also not sure I understand that this is a change, especially because that particular example is not a good one since the content of that file (i.e. sssql15-md.md) is:

SQL Server 2016 (13.x)

I have just created an issue to better explain / document what I was running into:

#3061

@srutzky srutzky deleted the patch-1 branch November 15, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

8 participants