-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update conversion notes in "decimal and numeric" and "float and real" pages #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes #2827
The behavior changed starting in SQL Server 2016. Please see my comments in #2827 for the test code.
Please check the include. The `CREATE TABLE` page uses `[!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]` but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, **sssql16**, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.
Additional testing (in another comment in #2827 ) clarified setting the `FLOAT` value via scientific notation vs decimal notation.
Same change as made on "float and real" page.
Fixes MicrosoftDocs#2827
The behavior changed starting in SQL Server 2016. Please see my comments in MicrosoftDocs#2827 for the test code.
Please check the include. The `CREATE TABLE` page uses `[!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]` but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, **sssql16**, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.
|
@srutzky : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Hi @srutzky - thank you for submitting this, I'm getting your PR reviewed. For the include files, we're now referring to version number instead of version name. SQL Server 2019 is SQL Server version 15, so the include file is named |
|
#sign-off |
|
@pmasl: I'm sorry - only the author of this article, @MikeRayMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias. |
|
#sign-off |
|
Hi @MikeRayMSFT
You are welcome.
Not sure if you understood what I was saying. Also not sure I understand that this is a change, especially because that particular example is not a good one since the content of that file (i.e. sssql15-md.md) is:
I have just created an issue to better explain / document what I was running into: #3061 |
Fixes #2827
The behavior changed starting in SQL Server 2016. Please see my comments in #2827 for the test code.
Please check the include reference. The
CREATE TABLEpage ( https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/t-sql/statements/create-table-transact-sql.md ) uses[!INCLUDE[ssSQL15](../../includes/sssql15-md.md)]but that is a bad name for the include file since there is no 2015 version. There is an identical include file with the correct name, sssql16, so I am using that instead. But, I have no way to test include files to hopefully there is no problem with the "16" file.Take care,
Solomon...
https://SqlQuantumLeap.com/