clean up CREATE ASYMMETRIC KEY #2200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes pertain to Issue #2198 .
Syntax section:
Arguments section:
AUTHORIZATIONto the top to match order in Syntax sectionFILEoptionEXECUTABLE FILEoptionASSEMBLYoptionPROVIDERENCRYPTION BY *\<key_name_in_provider>*as it is not a valid as stated (is part ofENCRYPTION BY PASSWORD-- see below)ALGORITHMup to match order of options shown in Syntax sectionPASSWORDto beENCRYPTION BY PASSWORDRemarks section:
Added "or DLL file" to end of 1st paragraph, regarding the
FROMclause (yes, DLL from either file system or as a loaded assembly -- same thing just different location -- only stores the public key)Removed 3rd sentence of 2nd paragraph -- "If a database master key does exist, the password is optional." -- as it contradicted the 2nd sentence, and was just incorrect. With no DMK, the following statement:
CREATE ASYMMETRIC KEY [AKeyNoPassword] WITH ALGORITHM = RSA_2048;gets the following error:
Examples section:
In example "B", for correctness changed
to be:
In example "B", for variety removed
ENCRYPTION BY PASSWORDclause as that is shown in example "A". Without this clause, the Database Master Key will be used, hence it must already exist. I added a sentence mentioning this to the end of the example description.In example "C", for correctness changed
to be:
In example "C", fixed name "EKMProvider1" to be "EKM_Provider1" (to match T-SQL statement) in example description
In example "C", not sure if lack of
ENCRYPTION BY PASSWORDimplies Database Master Key is used, or if that is a non-issue when using an EKM provider. I have never used an EKM provider so for now I am leaving that part as is (i.e. not mentioned in the example description).See Also section:
ASYMKEYPROPERTYandASYMKEY_ID