Skip to content

Update Installing-PowerShell-on-Windows.md#8264

Merged
sdwheeler merged 3 commits intoMicrosoftDocs:stagingfrom
philanderson888:patch-1
Oct 27, 2021
Merged

Update Installing-PowerShell-on-Windows.md#8264
sdwheeler merged 3 commits intoMicrosoftDocs:stagingfrom
philanderson888:patch-1

Conversation

@philanderson888
Copy link
Copy Markdown
Contributor

@philanderson888 philanderson888 commented Oct 27, 2021 •
edited
Loading

PR Summary

Existing notes on the correct way to install powershell using winget were inaccurate. I have added more complete notes which add installing by name, id and also version. The existing command using the exact parameter was incorrect so I have removed it.

PR Context

Select the area of the Table of Contents containing the documents being changed.

Conceptual content

  • Overview and Install
  • Learning PowerShell
    • PowerShell 101
    • Deep dives
    • Sample scripts
    • Remoting
  • Release notes (What's New)
  • Windows PowerShell
    • WMF, ISE, release notes, etc.
  • DSC articles
  • Community resources
  • Gallery articles
  • Scripting and development
    • Language Spec
    • Legacy SDK

Cmdlet reference & about_ topics

  • Preview content
  • Version 7.1 content
  • Version 7.0 content
  • Version 5.1 content

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [WIP] to the beginning of the
      title and remove the prefix when the PR is ready.

@philanderson888
Update Installing-PowerShell-on-Windows.md
4582838 
Existing notes on the correct way to install powershell using `winget` were inaccurate.  I have added more complete notes which add installing by name, id and also version.  The existing command using the `exact` parameter was incorrect so I have removed it.
@opbld31
Copy link
Copy Markdown

opbld31 commented Oct 27, 2021

Docs Build status updates of commit 4582838:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/Installing-PowerShell-on-Windows.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

sdwheeler
sdwheeler requested changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept my suggested change.

@philanderson888 @sdwheeler
Update reference/docs-conceptual/install/Installing-PowerShell-on-Win…
eeaff1a 
…dows.md

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
@opbld30
Copy link
Copy Markdown

opbld30 commented Oct 27, 2021

Docs Build status updates of commit eeaff1a:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/Installing-PowerShell-on-Windows.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

philanderson888
philanderson888 commented Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@philanderson888 philanderson888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sdwheeler - perfectly understand.

Changes approved.

Phil

@philanderson888
Update Installing-PowerShell-on-Windows.md
546fb21 
However I tried the syntax of your suggested change @sdwheeler and still found this syntax to be incorrect.  

I have therefore proposed a change which works syntactically and Powershell accepts.

Please review the changes and let me know what you think.

Thank you.
@opbld32
Copy link
Copy Markdown

opbld32 commented Oct 27, 2021

Docs Build status updates of commit 546fb21:

✅ Validation status: passed

File Status Preview URL Details
reference/docs-conceptual/install/Installing-PowerShell-on-Windows.md ✅Succeeded View (>=powershell-5.1)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sdwheeler sdwheeler merged commit 79262d8 into MicrosoftDocs:staging Oct 27, 2021
@sdwheeler
Copy link
Copy Markdown
Collaborator

sdwheeler commented Oct 27, 2021

I tried the syntax that I suggested and it works for me. But your latest change works as well so I am good with that.

Thanks for understanding and for the fix.

@philanderson888
Copy link
Copy Markdown
Contributor Author

philanderson888 commented Oct 27, 2021

Thank you @sdwheeler and glad to be of help; that's my first ever contribution to Microsoft

@philanderson888 philanderson888 deleted the patch-1 branch December 18, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdwheeler sdwheeler sdwheeler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@philanderson888 @opbld31 @opbld30 @opbld32 @sdwheeler