Skip to content

Fixes #5020 - add Get-Counter to v7 docs#5033

Merged
sdwheeler merged 3 commits intoMicrosoftDocs:stagingfrom
sdwheeler:sdw-ghi5020
Nov 6, 2019
Merged

Fixes #5020 - add Get-Counter to v7 docs#5033
sdwheeler merged 3 commits intoMicrosoftDocs:stagingfrom
sdwheeler:sdw-ghi5020

Conversation

@sdwheeler
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler commented Oct 30, 2019 •
edited
Loading

PR Summary

Fixes #5020 - add Get-Counter to v7 docs
Fixes AB#1638972
See PowerShell/PowerShell#10933

PR Context

Select the type(s) of documents being changed.

Cmdlet reference & about_ topics

  • Version 7 content
  • Version 6 content
  • Version 5.1 content

Conceptual articles

  • Fundamental conceptual articles
  • Script sample articles
  • DSC articles
  • Gallery articles
  • JEA articles
  • WMF articles
  • SDK articles

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the
      title and remove the prefix when the PR is ready.

@sdwheeler sdwheeler added the hold-for-pr Waiting - for PR merge label Oct 30, 2019
@sdwheeler sdwheeler added this to the Future milestone Oct 30, 2019
@sdwheeler sdwheeler requested a review from DCtheGeek October 30, 2019 22:05
@opbld32
Copy link
Copy Markdown

opbld32 commented Oct 30, 2019

Docs Build status updates of commit 94331b7:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

DCtheGeek
DCtheGeek suggested changes Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the date, otherwise it looks fine. The PowerShell blocks mostly had both the cmd and the output, which you normally separate into two codefences. Your call on leaving it this way or breaking them out.

@opbld33
Copy link
Copy Markdown

opbld33 commented Oct 30, 2019

Docs Build status updates of commit 87d07ae:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld30
Copy link
Copy Markdown

opbld30 commented Oct 30, 2019

Docs Build status updates of commit c128d08:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

DCtheGeek
DCtheGeek approved these changes Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved for when the source PR is merged.

@opbld33
Copy link
Copy Markdown

opbld33 commented Nov 6, 2019

Docs Build status updates of commit 0997eac:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Diagnostics/Get-Counter.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@sdwheeler sdwheeler merged commit d7ad38f into MicrosoftDocs:staging Nov 6, 2019
@sdwheeler sdwheeler removed the hold-for-pr Waiting - for PR merge label Nov 11, 2019
@sdwheeler sdwheeler modified the milestones: Future, 7.0.0 Nov 11, 2019
@sdwheeler sdwheeler deleted the sdw-ghi5020 branch November 12, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DCtheGeek DCtheGeek DCtheGeek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Bring back doc for Get-Counter cmdlet for PS7

5 participants

@sdwheeler @opbld32 @opbld33 @opbld30 @DCtheGeek