Skip to content

Fixes #5002 - add ogv, Show-Command, and ShowWindow to v7#5015

Merged
DCtheGeek merged 4 commits intoMicrosoftDocs:stagingfrom
sdwheeler:sdw-ghi5002
Nov 2, 2019
Merged

Fixes #5002 - add ogv, Show-Command, and ShowWindow to v7#5015
DCtheGeek merged 4 commits intoMicrosoftDocs:stagingfrom
sdwheeler:sdw-ghi5002

Conversation

@sdwheeler
Copy link
Copy Markdown
Collaborator

@sdwheeler sdwheeler commented Oct 28, 2019 •
edited by DCtheGeek
Loading

PR Summary

Fixes #5002 - add ogv and ShowWindow to v7
Fixes #5004 - improve example 7
Fixes AB#1632691
Fixes AB#1629377

PR Context

Select the type(s) of documents being changed.

Cmdlet reference & about_ topics

  • Version 7 content
  • Version 6 content
  • Version 5.1 content

Conceptual articles

  • Fundamental conceptual articles
  • Script sample articles
  • DSC articles
  • Gallery articles
  • JEA articles
  • WMF articles
  • SDK articles

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress
    • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the
      title and remove the prefix when the PR is ready.

@sdwheeler sdwheeler added the hold-for-pr Waiting - for PR merge label Oct 28, 2019
@sdwheeler sdwheeler added this to the Future milestone Oct 28, 2019
@sdwheeler sdwheeler requested a review from DCtheGeek October 28, 2019 21:46
@opbld31
Copy link
Copy Markdown

opbld31 commented Oct 28, 2019

Docs Build status updates of commit f79b9f6:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@opbld32
Copy link
Copy Markdown

opbld32 commented Oct 28, 2019

Docs Build status updates of commit efc300d:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

DCtheGeek
DCtheGeek suggested changes Oct 29, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple items to review.

@sdwheeler sdwheeler changed the title Fixes #5002 - add ogv and ShowWindow to v7 Fixes #5002 - add ogv, Show-Command, and ShowWindow to v7 Oct 30, 2019
@opbld34
Copy link
Copy Markdown

opbld34 commented Oct 30, 2019

Docs Build status updates of commit a221a3b:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Show-Command.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Show-Command.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@davidsmatlak davidsmatlak mentioned this pull request Oct 30, 2019
Closed
DCtheGeek
DCtheGeek approved these changes Oct 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DCtheGeek DCtheGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved, but needs to wait for the source PR to merge.

@sdwheeler sdwheeler modified the milestones: Future, 7.0.0 Nov 2, 2019
@sdwheeler sdwheeler removed the hold-for-pr Waiting - for PR merge label Nov 2, 2019
@opbld32
Copy link
Copy Markdown

opbld32 commented Nov 2, 2019

Docs Build status updates of commit 58a31d8:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Utility/Show-Command.md ✅Succeeded View (powershell-5.1)
reference/7/Microsoft.PowerShell.Core/Get-Help.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Out-GridView.md ✅Succeeded View (powershell-7)
reference/7/Microsoft.PowerShell.Utility/Show-Command.md ✅Succeeded View (powershell-7)

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@DCtheGeek DCtheGeek merged commit 65bf055 into MicrosoftDocs:staging Nov 2, 2019
@sdwheeler sdwheeler deleted the sdw-ghi5002 branch November 5, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DCtheGeek DCtheGeek DCtheGeek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

Example 7 Doesn't Work: Doc Out-Gridview, Show-Command and Get-Help -ShowWIndow for PS7

5 participants

@sdwheeler @opbld31 @opbld32 @opbld34 @DCtheGeek