Skip to content

Propose some documentation updates for PseudoConsole hang conditions.#100

Merged
miniksa merged 2 commits intomasterfrom
dev/miniksa/pseudo
Sep 19, 2019
Merged

Propose some documentation updates for PseudoConsole hang conditions.#100
miniksa merged 2 commits intomasterfrom
dev/miniksa/pseudo

Conversation

@miniksa
Copy link
Collaborator

@miniksa miniksa commented Aug 26, 2019

No description provided.

@bitcrazed
Copy link
Contributor

Docs Build status updates of commit 9b4e980:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/createpseudoconsole.md ⚠️Warning View Details
docs/creating-a-pseudoconsole-session.md ⚠️Warning View Details
docs/closepseudoconsole.md ✅Succeeded View

docs/createpseudoconsole.md

  • Line 45: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/Sync/synchronization-and-overlapped-input-and-output contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 48: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/Sync/synchronization-and-overlapped-input-and-output contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.

docs/creating-a-pseudoconsole-session.md

  • Line 23: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-readfile contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 23: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/fileapi/nf-fileapi-writefile contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 23: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/Sync/synchronization-and-overlapped-input-and-output contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 23: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/minwinbase/ns-minwinbase-_overlapped contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 41: [Warning] Link https://msdn.microsoft.com/en-us/library/windows/desktop/aa365152(v=vs.85).aspx contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 88: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/winbase/ns-winbase-_startupinfoexw contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 92: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-initializeprocthreadattributelist contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 94: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/processthreadsapi/nf-processthreadsapi-updateprocthreadattribute contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
  • Line 145: [Warning] Link https://docs.microsoft.com/en-us/windows/desktop/api/winbase/ns-winbase-_startupinfoexw contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@miniksa miniksa requested a review from carlos-zamora August 26, 2019 18:22
@miniksa
Copy link
Collaborator Author

miniksa commented Aug 26, 2019

OK I fixed the warnings in another PR (for the whole repo) and merged it in here. Should be gone now...

@bitcrazed
Copy link
Contributor

Docs Build status updates of commit 9bc8db3:

✅ Validation status: passed

File Status Preview URL Details
docs/closepseudoconsole.md ✅Succeeded View
docs/createpseudoconsole.md ✅Succeeded View
docs/creating-a-pseudoconsole-session.md ✅Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@miniksa
Copy link
Collaborator Author

miniksa commented Aug 26, 2019

@zadjii-msft, if you could give the wording a run through, I'd like your eyes before I merge this.

Copy link
Contributor

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I'm cool with these updates. This guidance is helpful to people even if we do fix the deadlock.

@miniksa miniksa merged commit 0149828 into master Sep 19, 2019
@miniksa miniksa deleted the dev/miniksa/pseudo branch September 19, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants