Added command translations for polish #4435

pypros · 2019-02-18T18:32:55Z

For #

Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Has sufficient logging.
Has telemetry for enhancements.
Unit tests & system/integration tests are added/updated
Test plan is updated as appropriate
package-lock.json has been regenerated by running npm install (if dependencies have changed)

msftclas · 2019-02-18T18:33:08Z

All CLA requirements met.

codecov · 2019-02-18T18:44:43Z

Codecov Report

Merging #4435 into master will increase coverage by 21%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4435     +/-   ##
========================================
+ Coverage      58%     78%    +21%     
========================================
  Files         366     442     +76     
  Lines       15753   20820   +5067     
  Branches     2455    3356    +901     
========================================
+ Hits         9022   16114   +7092     
+ Misses       6141    4701   -1440     
+ Partials      590       5    -585

Flag	Coverage Δ
#Linux	`66% <ø> (?)`
#Windows	`66% <ø> (?)`
#macOS	`66% <ø> (?)`

pypros · 2019-02-19T12:31:45Z

Hi @brettcannon,

I hope you are right person Brett. Could you help me deliver my firsts commits to repo? What I did wrong?

Br
Łukasz

brettcannon · 2019-02-20T20:02:46Z

@pypros LGTM! We're just having some CI instability which is why you see the failures.

pypros · 2019-02-20T20:08:40Z

How to rerun this tests? Sorry for stupid question but it is my first comments in open source.

brettcannon · 2019-02-20T20:08:52Z

I've asked on Twitter for feedback on the translation to help make sure we have the best Polish translation possible. 😄

pypros · 2019-02-20T20:10:49Z

For my point of me great idea. :)

soltysh

I left some comments

soltysh · 2019-02-20T20:22:27Z

package.nls.pl.json

+    "python.command.python.runtests.title": "Uruchom wszystkie testy jednostkowe",
+    "python.command.python.debugtests.title": "Debuguj wszystkie testy jednostkowe",
+    "python.command.python.execInTerminal.title": "Uruchom plik Pythonowy w terminalu",
+    "python.command.python.setInterpreter.title": "Wybierz wersje interpretera",


soltysh · 2019-02-20T20:26:17Z

package.nls.pl.json

+    "python.command.python.setInterpreter.title": "Wybierz wersje interpretera",
+    "python.command.python.updateSparkLibrary.title": "Zaktualizuj biblioteki w przestrzeni roboczej PySpark", 
+    "python.command.python.refactorExtractVariable.title": "Wypakuj zmienną",
+    "python.command.python.refactorExtractMethod.title": "Wypakuj metode",


Estrahuj will be much better, imo. Wypakuj is not quite what extract does here.

Wydobądź, wyizoluj, wybierz.

Wyodrębnij is another option.

soltysh · 2019-02-20T20:27:36Z

package.nls.pl.json

+    "python.command.python.refactorExtractMethod.title": "Wypakuj metode",
+    "python.command.python.viewOutput.title": "Przedstaw wyniki",
+    "python.command.python.viewTestOutput.title": "Przedstaw wyniki testów jednostkowych",
+    "python.command.python.selectAndRunTestMethod.title": "Uruchom metode testów jednostkowych ...", 


soltysh · 2019-02-20T20:27:44Z

package.nls.pl.json

+    "python.command.python.viewOutput.title": "Przedstaw wyniki",
+    "python.command.python.viewTestOutput.title": "Przedstaw wyniki testów jednostkowych",
+    "python.command.python.selectAndRunTestMethod.title": "Uruchom metode testów jednostkowych ...", 
+    "python.command.python.selectAndDebugTestMethod.title": "Debuguj metode testów jednostkowych ...", 


soltysh · 2019-02-20T20:28:03Z

package.nls.pl.json

+    "python.command.python.selectAndRunTestFile.title": "Uruchom plik z testami jednostkowymi ...",
+    "python.command.python.runCurrentTestFile.title": "Uruchom bieżący plik z testami jednostkowymi",
+    "python.command.python.runFailedTests.title": "Uruchom testy jednostwowe, które się nie powiodły",
+    "python.command.python.discoverTests.title": "Wyszykaj testy jednostkowe",


soltysh · 2019-02-20T20:29:37Z

package.nls.pl.json

+    "python.command.python.enableLinting.title": "Włącz linting",
+    "python.command.python.runLinting.title": "Uruchom linting",
+    "python.command.python.datascience.runallcells.command.title": "Uruchom bierzący plik w oknie IPythona",
+    "python.command.python.datascience.runallcells.title": "Urzuchom wszystkie komórki",


soltysh · 2019-02-20T20:30:03Z

package.nls.pl.json

+    "python.command.python.runLinting.title": "Uruchom linting",
+    "python.command.python.datascience.runallcells.command.title": "Uruchom bierzący plik w oknie IPythona",
+    "python.command.python.datascience.runallcells.title": "Urzuchom wszystkie komórki",
+    "python.command.python.datascience.runcurrentcell.title": "Urzuchom bierząca komórkę",


soltysh · 2019-02-20T20:30:10Z

package.nls.pl.json

+    "python.command.python.datascience.runallcells.command.title": "Uruchom bierzący plik w oknie IPythona",
+    "python.command.python.datascience.runallcells.title": "Urzuchom wszystkie komórki",
+    "python.command.python.datascience.runcurrentcell.title": "Urzuchom bierząca komórkę",
+    "python.command.python.datascience.runcurrentcelladvance.title": "Uruchom bierzące komórki i pokaż",


soltysh · 2019-02-20T20:31:06Z

package.nls.pl.json

+    "python.command.python.datascience.importnotebookonfile.title": "Importuj notatnik Jupyter",
+    "python.command.python.enableSourceMapSupport.title": "Włącz obsługę map źródłowych do debugowania rozszerzeń",
+    "python.command.python.datascience.exportoutputasnotebook.title": "Eksportuj okno IPython jako notatnik Jupyter",
+    "python.command.python.datascience.exportfileasnotebook.title": "Wyeksportuj bieżący plik Pythona jako notatnik Jupytera",


Be consistent and use either Eksportuj everywhere or Wyeksportuj. I'd personally go with the former.

This still holds.

soltysh · 2019-02-20T20:31:15Z

package.nls.pl.json

+    "python.command.python.enableSourceMapSupport.title": "Włącz obsługę map źródłowych do debugowania rozszerzeń",
+    "python.command.python.datascience.exportoutputasnotebook.title": "Eksportuj okno IPython jako notatnik Jupyter",
+    "python.command.python.datascience.exportfileasnotebook.title": "Wyeksportuj bieżący plik Pythona jako notatnik Jupytera",
+    "python.command.python.datascience.exportfileandoutputasnotebook.title": "Wyeksportuj bieżący plik Pythona i jego wyniki jako notatnik Jupytera",


So does this.

package.nls.pl.json

soltysh · 2019-02-20T20:47:55Z

package.nls.pl.json

+    "python.command.python.selectAndDebugTestMethod.title": "Debuguj metodę testów jednostkowych ...", 
+    "python.command.python.selectAndRunTestFile.title": "Uruchom plik z testami jednostkowymi ...",
+    "python.command.python.runCurrentTestFile.title": "Uruchom bieżący plik z testami jednostkowymi",
+    "python.command.python.runFailedTests.title": "Uruchom testy jednostwowe, które się nie powiodły",


jednostkowe

package.nls.pl.json

soltysh · 2019-02-20T20:48:59Z

package.nls.pl.json

+    "python.command.python.runLinting.title": "Uruchom linting",
+    "python.command.python.datascience.runallcells.command.title": "Uruchom bieżący plik w oknie IPythona",
+    "python.command.python.datascience.runallcells.title": "Uruchom wszystkie komórki",
+    "python.command.python.datascience.runcurrentcell.title": "Urzuchom bieżąca komórkę",


soltysh · 2019-02-20T20:49:22Z

package.nls.pl.json

+    "python.command.python.datascience.importnotebookonfile.title": "Importuj notatnik Jupyter",
+    "python.command.python.enableSourceMapSupport.title": "Włącz obsługę map źródłowych do debugowania rozszerzeń",
+    "python.command.python.datascience.exportoutputasnotebook.title": "Eksportuj okno IPython jako notatnik Jupyter",
+    "python.command.python.datascience.exportfileasnotebook.title": "Wyeksportuj bieżący plik Pythona jako notatnik Jupytera",


This still holds.

soltysh · 2019-02-20T20:49:34Z

package.nls.pl.json

+    "python.command.python.enableSourceMapSupport.title": "Włącz obsługę map źródłowych do debugowania rozszerzeń",
+    "python.command.python.datascience.exportoutputasnotebook.title": "Eksportuj okno IPython jako notatnik Jupyter",
+    "python.command.python.datascience.exportfileasnotebook.title": "Wyeksportuj bieżący plik Pythona jako notatnik Jupytera",
+    "python.command.python.datascience.exportfileandoutputasnotebook.title": "Wyeksportuj bieżący plik Pythona i jego wyniki jako notatnik Jupytera",


So does this.

soltysh · 2019-02-20T20:50:04Z

package.nls.pl.json

+    "python.command.python.datascience.exportfileasnotebook.title": "Wyeksportuj bieżący plik Pythona jako notatnik Jupytera",
+    "python.command.python.datascience.exportfileandoutputasnotebook.title": "Wyeksportuj bieżący plik Pythona i jego wyniki jako notatnik Jupytera",
+    "python.command.python.datascience.undocells.title": "Cofnij ostatnią akcję IPythona",
+    "python.command.python.datascience.redocells.title": "Ponów ostatnią  akcję IPythona",


You have double space between ostatnią and akcję, which is not necessary

soltysh · 2019-02-20T20:50:16Z

package.nls.pl.json

+    "python.command.python.datascience.redocells.title": "Ponów ostatnią  akcję IPythona",
+    "python.command.python.datascience.removeallcells.title": "Usuń wszystkie komórki IPythona",
+    "python.command.python.datascience.interruptkernel.title": "Przerwij IPython Kernel",
+    "python.command.python.datascience.restartkernel.title": "Restart IPython Kernel",


pypros · 2019-02-20T21:12:20Z

@soltysh thank you very much :)

soltysh

One final nit, but overall this lgtm 👍 Thanks for putting it together!

soltysh · 2019-02-21T10:55:29Z

package.nls.pl.json

+    "python.command.python.setInterpreter.title": "Wybierz wersję interpretera",
+    "python.command.python.updateSparkLibrary.title": "Zaktualizuj biblioteki w przestrzeni roboczej PySpark", 
+    "python.command.python.refactorExtractVariable.title": "Ekstrahuj zmienną",
+    "python.command.python.refactorExtractMethod.title": "Ekstrahuj metodę",


Yeah after @deshipu comments, I think we could change this to wyodrębnij.

szok · 2019-02-21T12:21:58Z

package.nls.pl.json

+    "python.command.python.refactorExtractVariable.title": "Ekstrahuj zmienną",
+    "python.command.python.refactorExtractMethod.title": "Ekstrahuj metodę",
+    "python.command.python.viewOutput.title": "Przedstaw wyniki",
+    "python.command.python.viewTestOutput.title": "Przedstaw wyniki testów jednostkowych",


Maybe "Pokaż wynik testów..." will be better?

szok · 2019-02-21T12:22:39Z

package.nls.pl.json

+    "python.command.python.runCurrentTestFile.title": "Uruchom bieżący plik z testami jednostkowymi",
+    "python.command.python.runFailedTests.title": "Uruchom testy jednostkowe, które się nie powiodły",
+    "python.command.python.discoverTests.title": "Wyszukaj testy jednostkowe",
+    "python.command.python.configureTests.title": "Skonfiguruj testy jednostkowe",


Skonfiguruj -> Konfiguruj ?

szok · 2019-02-21T12:23:22Z

package.nls.pl.json

+    "python.command.python.configureTests.title": "Skonfiguruj testy jednostkowe",
+    "python.command.python.execSelectionInTerminal.title": "Uruchom zaznaczony obszar w interpreterze Pythona",
+    "python.command.python.execSelectionInDjangoShell.title": "Uruchom zaznaczony obszar w powłoce Django",
+    "python.command.python.goToPythonObject.title": "Udaj się do obiektu Pythonowego",


Idź do obiektu?

pypros · 2019-02-21T21:05:38Z

@soltysh Did I do it right? I asking about squash all my git commits. After squash I used +master and force push only on my branch without "--force" for all repo. If something did wrong I have copy on my laptop. Can you confirm it?

programmer04

Suggestion about capital letters in adjectives and form of one word

programmer04

Suggestion about capital letters in adjectives and form of one word

programmer04

Suggestion about capital letters in adjectives and form of one word

programmer04

Suggestion about capital letters in adjectives and form of one word

programmer04 · 2019-02-22T09:54:39Z

package.nls.pl.json

+    "python.command.python.configureTests.title": "Konfiguruj testy jednostkowe",
+    "python.command.python.execSelectionInTerminal.title": "Uruchom zaznaczony obszar w interpreterze Pythona",
+    "python.command.python.execSelectionInDjangoShell.title": "Uruchom zaznaczony obszar w powłoce Django",
+    "python.command.python.goToPythonObject.title": "Idź do obiektu Pythonowego",


In Polish language adjectives don't start with capital letter. It should be pythonowego

programmer04 · 2019-02-22T09:54:42Z

package.nls.pl.json

+    "python.command.python.buildWorkspaceSymbols.title": "Zbuduj symbole dla przestrzeni roboczej", 
+    "python.command.python.runtests.title": "Uruchom wszystkie testy jednostkowe",
+    "python.command.python.debugtests.title": "Debuguj wszystkie testy jednostkowe",
+    "python.command.python.execInTerminal.title": "Uruchom plik Pythonowy w terminalu",


In Polish language adjectives don't start with capital letter. It should be pythonowy

programmer04 · 2019-02-22T09:55:24Z

package.nls.pl.json

+    "python.command.python.runLinting.title": "Uruchom linting",
+    "python.command.python.datascience.runallcells.command.title": "Uruchom bieżący plik w oknie IPythona",
+    "python.command.python.datascience.runallcells.title": "Uruchom wszystkie komórki",
+    "python.command.python.datascience.runcurrentcell.title": "Uruchom bieżąca komórkę",


bieżącą instead of bieżąca

soltysh · 2019-02-22T14:44:49Z

@soltysh Did I do it right? I asking about squash all my git commits. After squash I used +master and force push only on my branch without "--force" for all repo. If something did wrong I have copy on my laptop. Can you confirm it?

lgtm

@soltysh

Reviewers done @soltysh, @szok, @deshipu @programmer04

pypros · 2019-02-23T16:01:05Z

Fixes are done after review @programmer04 .

pypros · 2019-02-24T16:07:39Z

Ok, if everybody approved my changes what is next @brettcannon? What I have to do now for push my branch to master?

brettcannon · 2019-02-26T23:53:02Z

Thanks everyone for this! This will be included in the 2019.3/March release of the extension!

brettcannon approved these changes Feb 20, 2019

View reviewed changes

brettcannon added the external contributor label Feb 20, 2019

soltysh suggested changes Feb 20, 2019

View reviewed changes

soltysh approved these changes Feb 21, 2019

View reviewed changes

szok suggested changes Feb 21, 2019

View reviewed changes

pypros force-pushed the master branch from a09b02f to 10d2d5e Compare February 21, 2019 20:56

programmer04 suggested changes Feb 22, 2019

View reviewed changes

Added command translations for polish

5ae619f

Reviewers done @soltysh, @szok, @deshipu @programmer04

pypros force-pushed the master branch from 10d2d5e to 5ae619f Compare February 23, 2019 15:58

brettcannon merged commit 3745bd4 into microsoft:master Feb 26, 2019

lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019

Added command translations for polish #4435

Added command translations for polish #4435

Uh oh!

Conversation

pypros commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pypros commented Feb 19, 2019

Uh oh!

brettcannon commented Feb 20, 2019

Uh oh!

pypros commented Feb 20, 2019

Uh oh!

brettcannon commented Feb 20, 2019

Uh oh!

pypros commented Feb 20, 2019

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pypros commented Feb 20, 2019

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pypros commented Feb 18, 2019 •

edited

Loading

msftclas commented Feb 18, 2019 •

edited

Loading

codecov bot commented Feb 18, 2019 •

edited

Loading

programmer04 left a comment •

edited

Loading

pypros commented Feb 24, 2019 •

edited by brettcannon

Loading