Updating styling of PR description page#763
Merged
RMacfarlane merged 3 commits intomasterfrom Jan 7, 2019
Merged
Conversation
|
@RMacfarlane #354 Can this be addressed within this PR? I believe it would make the PR page look better. |
Member
|
It looks much better than before, great work! My only concern is Author infos of single comments stand out too much right now
since we stop showing separators between single comments, Author info looks similar to comments and as Author avatar is large, it stands out more than the real comments. Probably we can shrink it a little bit like what .com does. |
Contributor
Author
|
I decreased the size of the author information in review comments, and added the right indent back again:
@NavyAdmiral I'll take a look into that soon, but I think it's outside the scope of this PR |
838b6ba to
861ce68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it looks like this:
instead of