Show labels on PR description#556
Conversation
|
The code looks good, adding @misolori for advice on the UI. I think having a "Labels" heading somewhere would be nice. |
|
Thanks for taking a look at this! For the design, I'd probably move down into the body and use the
|
|
Here is the new look and I fixed a bug where multiple tags would have been rendered incorrectly, but got that fixed up here!
Edit: Also, rebased on to latest master. |
4fbef02 to
14ba23d
Compare
miguelsolorio
left a comment
There was a problem hiding this comment.
Nice work, this looks great!
One last minor thing, can you make sure the labels wrap if there are too many and/when the screen shrinks?
14ba23d to
a35c56a
Compare
|
@misolori Changes made. Used the same PR in your screenshot as my test so should work great now! Again rebased to latest master as well. |
Close #464
I'm not sure the design, but it should mimic GitHub's label design. I wen't ahead and not pulled in the color, so it is similar to the status badge. Feels like a lot of wasted space if there is a single label, so definitely open to changing up the design.
Without Labels:
With Labels: