-
Notifications
You must be signed in to change notification settings - Fork 720
Closed
Labels
Description
- Extension version: master
- VSCode Version: insiders (2018-09-25T07:23:31.537Z fe8d9d2470ddffb9dc2da604b23f5bd8a185cd66)
- OS:macOS
Steps to Reproduce:
- Clone a repo with pull requests
touch this_file_is_unrelated_to_anything- On some PR's description page, click
Checkout.
You'll see this:
Which is a damned lie. The message suggests stashing, which of course doesn't help, because the files in question aren't tracked.
Another repro, arguably worse:
- Clone a repo with pull requests
- Check out a branch that has an active PR
touch this_file_is_unrelated_to_anything- On the description page of the PR you're already on, click
Checkout.
This incarnation is particularly mind-bending (for me as a user), because to make it work, I have to because we don't have to do anything with git to satisfy the user's intent, which is entering review mode.
Anyway, when the user clicks that checkout button, we should probably just call into git and see what it says about changing branches, rather than trying to do its work for it.
Reactions are currently unavailable
