update the reset --quiet path codepath to pass the correct flags to the post-indexchanged hook#93
Merged
benpeart merged 1 commit intomicrosoft:vfs-2.20.0from Dec 13, 2018
benpeart:reset-quiet-post-indexchanged
Merged
update the reset --quiet path codepath to pass the correct flags to the post-indexchanged hook#93benpeart merged 1 commit intomicrosoft:vfs-2.20.0from benpeart:reset-quiet-post-indexchanged
benpeart merged 1 commit intomicrosoft:vfs-2.20.0from
benpeart:reset-quiet-post-indexchanged
Conversation
…he post-indexchanged hook In the reset --mixed code path, the index is created from scratch from the given commit by the call to read_from_tree(). Since this is the code that actually modifies the index, make sure we set the the_index.updated_skipworktree flag which is passed to the post-indexchanged hook. Updated the post-index-changed-hook test script to pass the --quiet flag so that we can prevent future regressions. Signed-off-by: Ben Peart <benpeart@microsoft.com>
kewillford
approved these changes
Dec 12, 2018
derrickstolee
pushed a commit
that referenced
this pull request
Dec 17, 2018
update the reset --quiet path codepath to pass the correct flags to the post-indexchanged hook
dscho
pushed a commit
that referenced
this pull request
Feb 27, 2019
update the reset --quiet path codepath to pass the correct flags to the post-indexchanged hook
dscho
pushed a commit
that referenced
this pull request
Mar 29, 2019
update the reset --quiet path codepath to pass the correct flags to the post-indexchanged hook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the reset --mixed code path, the index is created from scratch from the given commit by the call to read_from_tree(). Since this is the code that actually modifies the index, make sure we set the the_index.updated_skipworktree flag which is passed to the post-indexchanged hook.
Updated the post-index-changed-hook test script to pass the --quiet flag so that we can prevent future regressions.
Signed-off-by: Ben Peart benpeart@microsoft.com