Merged
Conversation
…not be deleted outright from memory).
Collaborator
Author
|
This will be a breaking change, because the user callback functions will need an extra method to be implemented. This is called when the delete is completed, in the rare case when a delete operation goes pending (this can happen during a CPR checkpoint). public void DeleteCompletionCallback(ref Key key, Context ctx) { } |
Contributor
|
Also, reads must make sure they are not reading a tombstone record. The liveness of a record needs to be checked everywhere. |
Collaborator
Author
|
Correct, reads have already been updated accordingly to return NOTFOUND. For log scans, right now I am returning deleted records as well. This is a debatable matter for resolution:
|
… An Upsert/RMW after a delete will create a new record at the tail. We never unset Tombstone bit - necessary for correctness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding native support for the record Delete operation in FASTER:
Note that from the perspective of recovery and CPR, deletes behave similarly to Upserts.
This checkin will replace the prior experimental method of
DeleteFromMemory.