jsrt: JsCreateExternalObjectWithPrototype #4267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Also sent nodejs/node-chakracore#429 to node-chakracore using this new API. |
MSLaguana
reviewed
Nov 17, 2017
| JsCopyStringOneByte | ||
| JsGetDataViewInfo | ||
| JsCreateExternalObjectWithPrototype | ||
| JsObjectGetProperty |
Contributor
There was a problem hiding this comment.
Were these missing accidentally prior to now?
MSLaguana
approved these changes
Nov 17, 2017
jackhorton
reviewed
Nov 17, 2017
Contributor
jackhorton
left a comment
There was a problem hiding this comment.
nit: don't the native tests generally use the Catch unittest framework for us?
Collaborator
Author
|
current design of the xplat native tests doesn't require |
chakrabot
pushed a commit
that referenced
this pull request
Nov 20, 2017
Merge pull request #4267 from obastemur:Jsrt_external_with_proto node-chakracore, each `ObjectTemplate` creation first creates an external object and sets prototype separately. `JsSetPrototype` is decently expensive to lazy call. This new `JsCreateExternalObjectWithPrototype` should supersede `JsCreateExternalObject` since prototype can be provided as `nullptr` if there is none. Also VS export Jsrt***ObjectProperty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-chakracore, each
ObjectTemplatecreation first creates an external object and sets prototype separately.JsSetPrototypeis decently expensive to lazy call.This new
JsCreateExternalObjectWithPrototypeshould supersedeJsCreateExternalObjectsince prototype can be provided asnullptrif there is none.Also VS export Jsrt***ObjectProperty