PERF Adding multi-output support to PWD implementation in KNeighborsClassifier#3
PERF Adding multi-output support to PWD implementation in KNeighborsClassifier#3
Conversation
|
I think you can and should use other structures than But I would focus our energy later on this PR as scikit-learn#24076 might be structured again with round of reviews. |
|
Just linking a comment for when you come back to this cython/cython#4966 (comment). I proposed using a list of Python objects wrapping memoryviews. I've only quickly skimmed this PR so I don't know if it actually does what you need though, so feel free to ignore if it isn't relevant. |
|
Thanks @da-woods for this proposal. I read this proposal in the original issue. Here, we might want to have instructions run as much as possible (or even solely) in |
No I agree. This is the big limitation of that suggestion. |
|
@Micky774 Is this implementation in a working state now? |
Reference Issues/PRs
Follows up work in #24076
What does this implement/fix? Explain your changes.
This PR develops proper multi-output support without wasted memory transfer
Any other comments?
Currently broken due to weird memory issues and segfaults surrounding the use of using
vector[memory_view]type structures. Opening this PR to share and get feedback.