Date flexibility and windows support#21
Merged
MichaelCurrin merged 4 commits intoMichaelCurrin:masterfrom Oct 9, 2021
Merged
Conversation
Owner
|
I see your My first thing this morning is to look at this repo, so glad the PR is up :) I'll try it in a container for Linux (I'm on a mac) |
Owner
|
It worked thanks. |
Contributor
Author
|
Great! Yeah, I just deleted my repo and re-forked it. |
Owner
|
I made some refactors and type check additions. Can you please verify all is working? on WSL you can run make commands like this will do all the CSV tasks make process |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK, I started again this time in a branch. You might want to try on real Linux before merging, I don't know how accurate WSL is regarding encoding issues.