Skip to content

Update GitHub Actions to match module template#95

Merged
Gudahtt merged 2 commits intomainfrom
update-github-actions
Apr 5, 2023
Merged

Update GitHub Actions to match module template#95
Gudahtt merged 2 commits intomainfrom
update-github-actions

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Apr 4, 2023

The GitHub Actions have been updated to match the latest version of the module template.

Notable changes include:

  • We now use setup-node for caching rather than manually caching dependencies.
  • The "all-jobs-pass" required status check has been split into two steps ("all-jobs-completed" and "all-jobs-pass") to ensure it runs even when a required job is skipped, ensuring that the status check itself is never skipped.
  • The obsolete require-additional-reviewer check has been removed.
  • Yarn v3 is now used for publishing rather than npm

This change relates to MetaMask/metamask-module-template#184 (this is a precursor to setting up the new doc publishing flow here to serve as an example)

The GitHub Actions have been updated to match the latest version of the
module template.

Notable changes include:
* We now use `setup-node` for caching rather than manually caching
dependencies.
* The "all-jobs-pass" required status check has been split into two
steps ("all-jobs-completed" and "all-jobs-pass") to ensure it runs even
when a required job is skipped, ensuring that the status check itself
is never skipped.
* The obsolete `require-additional-reviewer` check has been removed.
* Yarn v3 is now used for publishing rather than npm
@Gudahtt Gudahtt requested a review from a team as a code owner April 4, 2023 15:19
@Gudahtt Gudahtt marked this pull request as draft April 4, 2023 16:28
@Gudahtt Gudahtt marked this pull request as ready for review April 4, 2023 16:34
@Gudahtt Gudahtt merged commit e584d08 into main Apr 5, 2023
@Gudahtt Gudahtt deleted the update-github-actions branch April 5, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants