Add optional destroy method to Keyring type#108
Merged
mikesposito merged 1 commit intomainfrom Jun 20, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
destroyoptional method to theKeyringtype.Some keyrings like
@metamask/eth-trezor-keyringand@metamask/eth-ledger-bridge-keyringsupport this method to remove hardware bridges and in some cases (Ledger) to remove listeners.We need to add this method to the
Keyringbefore migrating Trezor and Ledger keyrings to this type.Changes
destroymethod onKeyringtypeReferences
destroymethod on Keyring type #107