Standardise all errors thrown in execution environments#1830
Merged
Conversation
packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
Outdated
Show resolved
Hide resolved
…tor.ts Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
@metamaskbot update-pr |
packages/snaps-execution-environments/src/common/lockdown/lockdown-more.ts
Outdated
Show resolved
Hide resolved
packages/snaps-execution-environments/src/common/lockdown/lockdown.ts
Outdated
Show resolved
Hide resolved
FrederikBolding
previously approved these changes
Oct 9, 2023
FrederikBolding
approved these changes
Oct 9, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1830 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 241 241
Lines 5591 5596 +5
Branches 881 881
=======================================
+ Hits 5366 5371 +5
Misses 225 225
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all errors thrown in
snaps-execution-environmentswith a JSON-RPC error usingeth-rpc-errors.Fixes #1823