Skip to content

fix: ts types file path in package.json#12

Merged
Gudahtt merged 1 commit intoMetaMask:mainfrom
mikesposito:fix/types-file-path
Dec 21, 2022
Merged

fix: ts types file path in package.json#12
Gudahtt merged 1 commit intoMetaMask:mainfrom
mikesposito:fix/types-file-path

Conversation

@mikesposito
Copy link
Copy Markdown
Member

@mikesposito mikesposito commented Dec 21, 2022

The ts types file path in package.json is not pointing to the right dist folder.

The package is at the moment throwing the following error while imported in other projects:
Could not find a declaration file for module '@metamask/scure-bip39'

Types path has been changed to ./dist/index.d.ts

@mikesposito mikesposito requested a review from a team as a code owner December 21, 2022 11:48
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 9e3501c into MetaMask:main Dec 21, 2022
@adonesky1 adonesky1 mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants