Skip to content

Fix typing of error data and stack properties#34

Merged
rekmarks merged 2 commits intomainfrom
type-fixup
Nov 17, 2020
Merged

Fix typing of error data and stack properties#34
rekmarks merged 2 commits intomainfrom
type-fixup

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Nov 17, 2020

If stack is present, it will be a string. This PR updates the SerializedEthereumRpcError interface to reflect this. Also fixes a couple of minor docstring / type errors.

@rekmarks rekmarks requested a review from a team as a code owner November 17, 2020 01:00
@rekmarks rekmarks changed the title Fix serialized error stack property Fix serialized error interface stack property Nov 17, 2020
Copy link
Copy Markdown

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks changed the title Fix serialized error interface stack property Fix typing of error data and stack properties Nov 17, 2020
@rekmarks
Copy link
Copy Markdown
Member Author

@rekmarks rekmarks merged commit 04249aa into main Nov 17, 2020
@rekmarks rekmarks deleted the type-fixup branch November 17, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants