Skip to content

Migrate from ES2018 to ES2017#26

Merged
Gudahtt merged 1 commit intomasterfrom
migrate-to-ES2017
Aug 18, 2020
Merged

Migrate from ES2018 to ES2017#26
Gudahtt merged 1 commit intomasterfrom
migrate-to-ES2017

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 18, 2020

The repository has been migrated from ES2018 to ES2017. The only change was replacing the Object spread operator with Object.assign. This was done primarily because the MetaMask extension uses a build tool (esprima) that isn't compatible with this operator. The MetaMask extension also supports certain browser versions (Chrome <v60) that don't support this operator.

The repository has been migrated from ES2018 to ES2017. The only change
was replacing the Object spread operator with `Object.assign`. This was
done primarily because the MetaMask extension uses a build tool
(`esprima`) that isn't compatible with this operator. The MetaMask
extension also supports certain browser versions (Chrome <v60) that
don't support this operator.
@Gudahtt Gudahtt requested a review from a team as a code owner August 18, 2020 19:21
Copy link
Copy Markdown
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 335fa50 into master Aug 18, 2020
@Gudahtt Gudahtt deleted the migrate-to-ES2017 branch August 18, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants