Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/rpc-errors
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.0
Choose a base ref
...
head repository: MetaMask/rpc-errors
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.0
Choose a head ref
  • 4 commits
  • 16 files changed
  • 4 contributors

Commits on Sep 27, 2024

  1. chore: Bump minimum Node version (#154)

    Bumps the minimum node version from 16 to 18, updates the minimum
    versions for 18, 20, and 22.
    rekmarks authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    39b34e2 View commit details
    Browse the repository at this point in the history
  2. chore: Migrate to Yarn 4, use JS constraints (#156)

    Migrates from Yarn 3 to 4 and replaces `constraints.pro` with JavaScript
    constraints via `yarn.config.cjs`. Migrating to Yarn 4 required a change
    to the Node / Yarn install flow in CI, which we solve by simply
    copypasting the workflows from the module template as of
    https://github.com/MetaMask/metamask-module-template/tree/570f6c2b80cb14fd61d5325131337401ae65c159.
    rekmarks authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    156c5c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. feat: Preserve original messages during error serialization by default (

    #158)
    
    This ensures that non-empty string `error.message` properties of
    serialized errors are preserved by default, even if the serialized error
    is not [a valid JSON-RPC
    error](https://www.jsonrpc.org/specification#error_object). This
    behavior can be overridden by setting `shouldPreserveMessage: false`.
    
    In #61, our error serialization logic was considerably improved. One of
    the behavioral changes made at the time was to always overwrite the
    `message` property with that of the fallback error (practically always
    the "internal JSON-RPC-error"), regardless of whether a non-empty string
    message was present on the original error object. We have yet to ship
    this everywhere in our stack, in part because such a change may be
    breaking for our consumers. By reverting to the old behavior for the
    `message` property only, we avoid these potential breakages and improve
    the accessibility of potentially useful information to consumers (i.e.
    directly in the error message as opposed to buried in
    `error.data.cause.message`).
    rekmarks authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    807a177 View commit details
    Browse the repository at this point in the history
  2. 7.0.0 (#160)

    This is the release candidate for version 7.0.0.
    
    ---------
    
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
    Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
    4 people authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a659bc6 View commit details
    Browse the repository at this point in the history
Loading