Conversation
This change migrates the source files to TypeScript, leaving just the tests written in JS. This allows us to auto-generate type definitions for the project and to ensure a basic set of type safety. The test files can be updated in a separate PR, optionally.
rekmarks
reviewed
Oct 27, 2020
rekmarks
requested changes
Oct 27, 2020
Member
rekmarks
left a comment
There was a problem hiding this comment.
Neat!
Just some questions and nits.
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Gudahtt
reviewed
Oct 30, 2020
| "lint": "eslint .", | ||
| "build": "tsc --project .", | ||
| "test": "yarn build && tape test/**/*.js", | ||
| "lint": "yarn build && eslint test/*.js", |
Member
There was a problem hiding this comment.
It looks like the .ts files aren't being linted? 🤔
Contributor
Author
There was a problem hiding this comment.
They aren't, no. That's a separate PR.
Contributor
Author
There was a problem hiding this comment.
I wanted to make minimal changes to the JS source to facilitate review. Linting the TS sources would add a lot of changes/noise to the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
This change migrates the source files to TypeScript, leaving just the tests written in JS. This allows us to auto-generate type definitions for the project and to ensure a basic set of type safety.
The test files can be updated in a separate PR, optionally.