Replace await-semaphore with async-mutex#15
Merged
Conversation
|
LGTM, though wondering why you didn't select the most recent version of the package? |
darkwing
previously approved these changes
May 11, 2021
Member
Author
|
Huh - it was the most recent version the last time I checked! I'll take a look at the new one. |
We've had issues with `await-semaphore` causing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned. `async-mutex` is more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.
b1b6472 to
0198e68
Compare
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had issues with
await-semaphorecausing TypeScript errors due to mistakes in how it is packaged. It generally seems to be abandoned.async-mutexis more actively maintained, has better documentation and test coverage, and is API-compatible for our usage.