You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like when we validate the changelogs in CI, we manually run yarn auto-changelog. Perhaps we should not do this anymore? I see that we are doing this because we may need to pass --rc depending on whether the current branch is a release branch or not, but we could extract the existing lint:changelog package script to a shell script and then add the same if statement that exists in the CI config. That way it gets run consistently locally and in CI.
It looks like when we validate the changelogs in CI, we manually run yarn auto-changelog. Perhaps we should not do this anymore? I see that we are doing this because we may need to pass --rc depending on whether the current branch is a release branch or not, but we could extract the existing lint:changelog package script to a shell script and then add the same if statement that exists in the CI config. That way it gets run consistently locally and in CI.
I just swapped it out for yarn lint:changelog, which seems to work fine, and seems easier than adding a script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables Prettier for changelog validation.