Skip to content

Update node.engines field in package.json#216

Merged
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:node-engines-update
Nov 15, 2023
Merged

Update node.engines field in package.json#216
legobeat merged 3 commits intoMetaMask:mainfrom
legobeat:node-engines-update

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

This should more correctly reflect actual intended support in most cases:

  • Odd-numbered versions are effectively ephemeral and supporting anything but the most recent doesn't seem meaningful
  • Signaling recent minors for maintenance/LTS in means less overhead in supporting the older runtimes.

@legobeat legobeat force-pushed the node-engines-update branch from fe8a276 to dd57987 Compare July 31, 2023 16:00
@legobeat legobeat marked this pull request as ready for review July 31, 2023 16:00
@legobeat legobeat requested a review from a team July 31, 2023 16:00
@legobeat legobeat requested a review from mcmire August 1, 2023 00:52
@legobeat legobeat requested a review from a team August 8, 2023 09:47
@legobeat legobeat force-pushed the node-engines-update branch from 66c92e9 to 6fb639b Compare October 13, 2023 06:44
legobeat and others added 2 commits October 31, 2023 00:56
Co-authored-by: Elliot Winkler <elliot.winkler@gmail.com>
@legobeat legobeat force-pushed the node-engines-update branch from 6fb639b to 83802ab Compare October 31, 2023 00:56
@legobeat legobeat requested a review from a team October 31, 2023 00:56
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Let's do it!

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 085b701 into MetaMask:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants