fix: create nft auto detection modal and remove nft polling logic by sahar-fehri · Pull Request #9857 · MetaMask/metamask-mobile

sahar-fehri · 2024-06-05T13:31:45Z

Description

This PR removes any code that triggers polling on NftDetectionController.

Calling detectNfts() function is now only triggered when the user clicks on the NFT tab.

It also Enables NFTDetection by default for new users.

Note

this PR has an asset-cpntroller patch from this core PR #4281
This patch keeps NFTDetection controller extending the polling controller while the PR makes it extend BaseController but it makes sure the polling is not triggered anymore in the client code.
It will be fully updated in newer versions of assets-controllers
I removed what triggers the start() of the polling, and now instead, mobile calls detectNfts() directly.
Then i made updates on the fct getOwnerNfts so that it only fetches information for a specific cursor instead of looping through all user nfts.
The loop is now being done inside the detectNfts() fct, and we basically fetch the first page of NFTs and save it to state so its available to clients to view.

New functionalities highlight:

1- Enable NFT autodetection by default to new users.
2- Old users who have the NFT autodetection off will see the new NFT detection modal to encourage them to enable the modal.
3- When users click on the banner notice, they are no longer directed to settings and instead we enable the NFT detection after they click on “enable nft autodetection” and we show the Toast. We wanted to reduce friction and we removed that redirection to settings.
4- The code should not do any of the 3mins polling in the background anymore.

Related issues

Related: MetaMask/core#4281

Manual testing steps

Import MM application
Go to settings => Security and privacy and you should see that the NFT detection is enabled.
Go back to home page and click on NFT tab; you should be able to see your NFTs being added.
Switch to another account that has NFTs
Click on NFTs tab and you should also see your NFTs being added to sate.
Go to settings => Security and privacy and turn OFF the NFT detection toggle.
You should see a new modal. Clicking on "allow" button should re-enable the NFT detection toggle.

Screenshots/Recordings

Before

Screen.Recording.2024-06-10.at.15.40.23.mov

After

Testing a fresh wallet import:

after-.mov

Testing an upgrade scenario:

First build on main, where you should see the NFT auto detection disabled by default if the user did not enable it

Then build on this PR:
You should see the new NFT detection modal and clicking on allow button should enable the NFT detection in the settings.

Screen.Recording.2024-06-10.at.15.45.02.mov

NFT detection banner with new Toast:

Screen.Recording.2024-06-14.at.13.15.50.mov

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-05T13:31:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

This reverts commit f4a1226.

codecov-commenter · 2024-06-10T18:24:45Z

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.22%. Comparing base (b013c71) to head (24c6caa).
Report is 57 commits behind head on main.

❗ Current head 24c6caa differs from pull request most recent head c061bab

Please upload reports for the commit c061bab to get more accurate results.

Files	Patch %	Lines
app/components/Views/Wallet/index.tsx	76.92%	2 Missing and 1 partial ⚠️
...ws/NFTAutoDetectionModal/NFTAutoDetectionModal.tsx	89.47%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9857      +/-   ##
==========================================
+ Coverage   47.24%   48.22%   +0.97%     
==========================================
  Files        1370     1401      +31     
  Lines       33304    33865     +561     
  Branches     3586     3671      +85     
==========================================
+ Hits        15736    16330     +594     
+ Misses      16607    16526      -81     
- Partials      961     1009      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-06-10T18:27:56Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c061bab
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7095807b-fab4-4ade-abbb-1fe478e12ff3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini

LGTM! Feel free to resolve the comments, or if you do any changes regarding them ping me to re approve it!
There is a lint issue on CollectibleDetectionModal

metamaskbot · 2024-06-25T11:56:43Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: deb5a4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0c416c40-e987-4e75-9a14-7758249c417e

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-25T13:30:43Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: deb5a4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9566320b-b82e-41ee-bc66-ee256f636813

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T14:06:10Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: deb5a4a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9566320b-b82e-41ee-bc66-ee256f636813

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-25T14:58:20Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cortisiko

🌮 🌮 🌮 🌮 🌮 🌮

metamaskbot · 2024-06-25T15:26:27Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:26:32Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:27:13Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:27:13Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:27:45Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:29:16Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-25T15:29:44Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0dfe239e-8872-4c03-bfb9-de0d305a1356

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:30:40Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:31:07Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:31:32Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T15:33:53Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a6b3b00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/683edcfc-816c-4a72-91bb-5ef0ac3cf6db

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-06-25T15:38:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-06-25T16:22:26Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0dfe239e-8872-4c03-bfb9-de0d305a1356

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-25T16:50:15Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf27218f-edda-40af-93b7-b89fa6e1440d

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T17:20:40Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf27218f-edda-40af-93b7-b89fa6e1440d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T17:25:42Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bf27218f-edda-40af-93b7-b89fa6e1440d

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T20:04:44Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/652cb227-f5ad-49df-b0ba-930b2237d896

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-06-25T21:30:17Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bfe23d7a-88b1-497a-847c-4fe9c8ffc21a

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

metamaskbot · 2024-06-25T22:06:43Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 899d714
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bfe23d7a-88b1-497a-847c-4fe9c8ffc21a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sahar-fehri requested a review from a team June 5, 2024 13:31

sahar-fehri requested a review from a team as a code owner June 5, 2024 13:31

sahar-fehri marked this pull request as draft June 5, 2024 13:31

fix: create nft auto detection modal and remove nft polling logic

e0abc2e

sahar-fehri force-pushed the feat/call-nft-detection-on-components branch from 72d4c1b to e0abc2e Compare June 10, 2024 08:18

sahar-fehri added 8 commits June 10, 2024 13:08

fix: fix patch

45f2cfc

fix: fix

66be754

fix: fix

de5c3fc

fix: fix

d1a0702

fix: fix

d9d6299

fix: fix

e8eee4a

fix: fix

f655a98

fix: fix

a01ecaf

sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels Jun 10, 2024

sahar-fehri added 7 commits June 10, 2024 16:54

fix: fix test

dc031a2

fix: test

f4a1226

empty commit

e8088d2

Revert "fix: test"

400f465

This reverts commit f4a1226.

fix: revert and re-apply changes

72948df

fix: update test

24c6caa

fix: lint

c061bab

sahar-fehri added the Run Smoke E2E label Jun 10, 2024

sahar-fehri added Run Smoke E2E and removed Run Smoke E2E labels Jun 10, 2024

tommasini previously approved these changes Jun 25, 2024

View reviewed changes

sahar-fehri added 2 commits June 25, 2024 12:59

fix: fix lint

9e69501

fix: update test type

deb5a4a

tommasini previously approved these changes Jun 25, 2024

View reviewed changes

fix: refactor test name

899d714

cortisiko approved these changes Jun 25, 2024

View reviewed changes

tommasini approved these changes Jun 25, 2024

View reviewed changes

Uh oh!

Conversation

sahar-fehri commented Jun 5, 2024 • edited by NicolasMassart Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 5, 2024

Uh oh!

codecov-commenter commented Jun 10, 2024

Codecov Report

Uh oh!

github-actions bot commented Jun 10, 2024 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

tommasini left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

github-actions bot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

github-actions bot commented Jun 25, 2024

Bitrise

Uh oh!

cortisiko left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

github-actions bot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

sonarqubecloud bot commented Jun 25, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jun 25, 2024

Bitrise

Uh oh!

github-actions bot commented Jun 25, 2024

sahar-fehri commented Jun 5, 2024 •

edited by NicolasMassart

Loading

github-actions bot commented Jun 10, 2024 •

edited by metamaskbot

Loading