You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem: We want to roll out Reservoir to Extension and Mobile similar to how we have done in Portfolio.
Requirements:
Define a way to compare OpenSea’s spam filtering and Reservoir’s spam filtering. Ideally the spam filtering is similar.
Create Core PR to migrate calls from OS to Reservoir.
Create PR on mobile to migrate from OS to Reservoir.
Create Extension PR to migrate from OS to Reservoir
Define roll out plan for Extension and Mobile
Roll out Reservoir to Extension and Mobile
Today, to get the NFTs core is calling opensea V2 api to fetch user nfts and to add new nfts (get NFT metadata)
In this ticket we wanted to call Reservoir API instead of calling openseaV2.
We are not changing any of the functional behaviors of the app, we are just swapping third party providers.
So the app should behave the exact same regarding any NFT related functionality:
Like showing NFT details when clicking on the NFT
And being able to remove/add the NFT
Mark it as favorite
Sending NFts
Manual testing steps
Go to the NFT tab
You should see your NFTs
Adding/removing NFTs should still work as expected
clicking on the NFT and seeing the NFT details should work as expected.
Screenshots/Recordings
The NFT tab should behave the same. You should be able to see the same NFTs you had.
Only thing noticed while testing is for some collections you might see either a different image or the mobile default image (if the new third party provider was not able to return the image)
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Hey @sahar-fehri this PR looks good to me, but can we have a recording with the nft auto detect and custom import to have a history of how it was the functionality now? It's good as well to record playing around with the IPFS Gateway Enabled and Display Nft Media privacy toggles to make sure the privacy features
Hey @sahar-fehri this PR looks good to me, but can we have a recording with the nft auto detect and custom import to have a history of how it was the functionality now? It's good as well to record playing around with the IPFS Gateway Enabled and Display Nft Media privacy toggles to make sure the privacy features
Thanks @tommasini 🙏 i added videos to the description!
You might notice that after the migration some collection logos might look different. This is because the new third party provider is returning sometimes the nft image and not the collection image. I think this is not a blocker to the rollout and we can check this with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds patches to mobile to enable Open Sea (OS) migration.
Related issues
MMASSETS-156. (Restricted access Jira issue)
Main core PR: MetaMask/core#4030
Core Compare link used to create the assets patch: https://github.com/MetaMask/core/compare/patch/mobile-assets-controllers-v-18-0-0...patch/mobile-assets-controllers-v-18-0-0-os-migration-v2?expand=1
Context
Problem: We want to roll out Reservoir to Extension and Mobile similar to how we have done in Portfolio.
Requirements:
Define a way to compare OpenSea’s spam filtering and Reservoir’s spam filtering. Ideally the spam filtering is similar.
Create Core PR to migrate calls from OS to Reservoir.
Create PR on mobile to migrate from OS to Reservoir.
Create Extension PR to migrate from OS to Reservoir
Define roll out plan for Extension and Mobile
Roll out Reservoir to Extension and Mobile
Today, to get the NFTs core is calling opensea V2 api to fetch user nfts and to add new nfts (get NFT metadata)
In this ticket we wanted to call Reservoir API instead of calling openseaV2.
We are not changing any of the functional behaviors of the app, we are just swapping third party providers.
So the app should behave the exact same regarding any NFT related functionality:
Like showing NFT details when clicking on the NFT
And being able to remove/add the NFT
Mark it as favorite
Sending NFts
Manual testing steps
Screenshots/Recordings
The NFT tab should behave the same. You should be able to see the same NFTs you had.
Only thing noticed while testing is for some collections you might see either a different image or the mobile default image (if the new third party provider was not able to return the image)
Before
Screen.Recording.2024-05-08.at.00.15.48.mov
Screen.Recording.2024-05-08.at.01.38.49.mov
After
Screen.Recording.2024-05-07.at.23.44.39.mov
Screen.Recording.2024-05-08.at.00.08.08.mov
Pre-merge author checklist
Pre-merge reviewer checklist