Skip to content

fix: include blockaid parameters in metrics of send flow#9453

Merged
jpuri merged 5 commits intomainfrom
blockaid_metrics_fix
May 3, 2024
Merged

fix: include blockaid parameters in metrics of send flow#9453
jpuri merged 5 commits intomainfrom
blockaid_metrics_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Apr 30, 2024

Description

Include blockaid data in metrics on send from inside the app.

Related issues

Fixes: #8824

Manual testing steps

  1. Submit a transaction to a malicious address, ensure that error is reported by blockaid
  2. Check that the send metrics events include blockaid results

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team Run Smoke E2E labels Apr 30, 2024
@jpuri jpuri requested a review from a team as a code owner April 30, 2024 09:02
@jpuri jpuri requested a review from a team April 30, 2024 09:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 30, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7d12239
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/02e5adcc-2faa-4cc1-956b-3a81cc3191ee

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

matthewwalsh0
matthewwalsh0 reviewed Apr 30, 2024
View reviewed changes
@jpuri jpuri requested review from bschorchit and matthewwalsh0 May 1, 2024 17:04
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 527c6f8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b4ab111-311c-4767-99b5-9b1288f813b9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri merged commit 1cd2a0c into main May 3, 2024
@jpuri jpuri deleted the blockaid_metrics_fix branch May 3, 2024 23:57
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 3, 2024
@metamaskbot metamaskbot added the release-7.23.0 Issue or pull request that will be included in release 7.23.0 label May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@bschorchit bschorchit Awaiting requested review from bschorchit

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.23.0 Issue or pull request that will be included in release 7.23.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - No blockaid data is included in Metrics events for transactions triggered from inside the wallet

7 participants

@jpuri @OGPoyraz @pedronfigueiredo @matthewwalsh0 @digiwand @bschorchit @metamaskbot