Initial *.metafi and *.metaswap URL migrations#9388
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
@kylanhurt Can you add the new domain in the description to make it easier to tell what should be changed? |
|
sethkfman
left a comment
There was a problem hiding this comment.
LGTM. 1 small clarifying question, then confirm E2E passes and reach out to Ramps and Tx team for review
wachunei
left a comment
There was a problem hiding this comment.
Just a small change request: for all occurrences of *.metafi-dev.codefi.network/* the url to used should be *.dev-api.cx.metamask.io/* (ie: use dev-api instead of api for metafi-dev).
I pointed out a case below.
|
Looks good to me! I'm just curious know if we need to updated these occurences of
Abd these occurences of |
This reverts commit e0a7b90.
|
@gauthierpetetin The patch files should eventually be updated by the controller upgrades. |
|
I understand that the controllers will be upgraded at some point in Mobile but since we don't know yet exactly when that will be the case, can we not keep the patches in the meanwhile, such that we can announce API Platform team that we don't use the deprecated urls anymore, as soon as this PR is merged? |
|
|
|
|
Description
*.metafiand*.metaswapsubdomains, in favour of*.api.cx.metamask.io, are going to be sunsetted in favor of a new subdomain / URL scheme. As a result, we need to migrate the relevant URLs in the application to there new equivalents while making sure that none of the links or assets breakRelated issues
Fixes: https://github.com/orgs/MetaMask/projects/60/views/6?pane=issue&itemId=59223328
Manual testing steps
price.api.cx.metamask.io/v1/______Screenshots/Recordings
Before
n/a, calls were getting status 200 before
After
An example:
Pre-merge author checklist
Pre-merge reviewer checklist