Skip to content

feat: Bump Build Number to 1315#9359

Merged
MarioAslau merged 1 commit intorelease/7.21.0from
chore/bump-build-to-1315
Apr 22, 2024
Merged

feat: Bump Build Number to 1315#9359
MarioAslau merged 1 commit intorelease/7.21.0from
chore/bump-build-to-1315

Conversation

@MarioAslau
Copy link
Copy Markdown
Contributor

@MarioAslau MarioAslau commented Apr 22, 2024

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@MarioAslau MarioAslau requested a review from a team April 22, 2024 19:24
@MarioAslau MarioAslau requested a review from a team as a code owner April 22, 2024 19:24
@MarioAslau MarioAslau self-assigned this Apr 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau requested a review from sethkfman April 22, 2024 19:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sethkfman
sethkfman approved these changes Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioAslau MarioAslau merged commit 46838e5 into release/7.21.0 Apr 22, 2024
@MarioAslau MarioAslau deleted the chore/bump-build-to-1315 branch April 22, 2024 19:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 25, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Apr 25, 2024

No release label on PR. Adding release label release-7.21.0 on PR, as PR was added to branch 7.21.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MarioAslau MarioAslau

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarioAslau @metamaskbot @sethkfman