Skip to content

chore: cherry-pick #9283#9289

Merged
chrisleewilcox merged 1 commit intorelease/7.21.0from
chore/cherry-pick-9283
Apr 17, 2024
Merged

chore: cherry-pick #9283#9289
chrisleewilcox merged 1 commit intorelease/7.21.0from
chore/cherry-pick-9283

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

This PR cherry-picks #9283

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

- Issue with `generateRawSignature` that didn't include the
`isWalletConnect` property.
- Issue undetected because of a missing type (set as any) in the method
signature.

## **Related issues**

Fixes: #9246

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions bot commented Apr 17, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e13c08a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ab4ccea8-f125-4103-abb7-1c34d4479daa

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox added release-7.21.0 Issue or pull request that will be included in release 7.21.0 Run Smoke E2E and removed Run Smoke E2E labels Apr 17, 2024
@chrisleewilcox
Copy link
Copy Markdown
Contributor

Failure for iOS related confirmation tests is a known issue and being addressed.

@github-actions
Copy link
Copy Markdown
Contributor Author

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label Apr 17, 2024
@chrisleewilcox chrisleewilcox marked this pull request as ready for review April 17, 2024 20:16
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner April 17, 2024 20:16
Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit f1a8118 into release/7.21.0 Apr 17, 2024
@chrisleewilcox chrisleewilcox deleted the chore/cherry-pick-9283 branch April 17, 2024 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-7.21.0 Issue or pull request that will be included in release 7.21.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants