Skip to content

feat: add notifications onboarding wizard#9263

Merged
Jonathansoufer merged 40 commits intomainfrom
feat/notifications-onboarding-wizard
Apr 23, 2024
Merged

feat: add notifications onboarding wizard#9263
Jonathansoufer merged 40 commits intomainfrom
feat/notifications-onboarding-wizard

Conversation

@Jonathansoufer
Copy link
Copy Markdown
Contributor

@Jonathansoufer Jonathansoufer commented Apr 16, 2024 •
edited
Loading

Description

This PR implements a new step on the onboarding wizard to teach users about notifications feature.

Related issues

N/A

Manual testing steps

Install a fresh app and accept the tour at beginning.

Screenshots/Recordings

Screen.Recording.2024-04-17.at.23.24.42.mov

After

Screenshot 2024-04-16 at 17 37 21

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Apr 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Jonathansoufer Jonathansoufer added team-mobile-platform Mobile Platform team team-notifications-deprecated DEPRECATED: please use "team-assets" instead labels Apr 16, 2024
@Jonathansoufer Jonathansoufer marked this pull request as ready for review April 16, 2024 13:41
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner April 16, 2024 13:41
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 16, 2024
@Jonathansoufer Jonathansoufer changed the title feat: notifications onboarding wizard feat: add notifications onboarding wizard Apr 16, 2024
@Jonathansoufer Jonathansoufer added Run Smoke E2E and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Apr 16, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 16, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cbd9181
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a1c341e-b4ac-4397-b718-3462100c6dfb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer mentioned this pull request Apr 16, 2024
Merged
7 tasks
Cal-L
Cal-L reviewed Apr 16, 2024
View reviewed changes
Cal-L
Cal-L reviewed Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the screenshot. Could you also provide a video of you going through the entire onboarding wizard? Let's also resolve the invalid PR template as well as E2E test failures

@Jonathansoufer
Copy link
Copy Markdown
Contributor Author

Jonathansoufer commented Apr 17, 2024

Thanks for the screenshot. Could you also provide a video of you going through the entire onboarding wizard? Let's also resolve the invalid PR template as well as E2E test failures

added

@Jonathansoufer Jonathansoufer requested a review from Cal-L April 17, 2024 22:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 403c952
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/71534c8a-87a4-4267-b0e2-c261475315e1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer requested a review from Cal-L April 19, 2024 17:10
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6a598a3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/077061cb-ca0d-4990-8fbd-38e4409635a5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4b3084f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a063154d-fb03-41a4-a75c-51a70fe777ac

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgewrmarshall
georgewrmarshall reviewed Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve after @Cal-L and @MetaMask/mobile-devs approval 👍

@Jonathansoufer
Copy link
Copy Markdown
Contributor Author

Jonathansoufer commented Apr 22, 2024

Can approve after @Cal-L and @MetaMask/mobile-devs approval 👍

@Cal-L is OoO. @sethkfman Could you take a look on this PR, please?

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
32.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Jonathansoufer Jonathansoufer merged commit eb74bd0 into main Apr 23, 2024
@Jonathansoufer Jonathansoufer deleted the feat/notifications-onboarding-wizard branch April 23, 2024 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
@Jonathansoufer Jonathansoufer restored the feat/notifications-onboarding-wizard branch April 24, 2024 20:03
@gauthierpetetin gauthierpetetin added release-7.22.0 Issue or pull request that will be included in release 7.22.0 and removed release-7.28.0 labels Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall left review comments

@brianacnguyen brianacnguyen brianacnguyen approved these changes

@Cal-L Cal-L Awaiting requested review from Cal-L

Assignees

@Jonathansoufer Jonathansoufer

Labels

release-7.22.0 Issue or pull request that will be included in release 7.22.0 team-mobile-platform Mobile Platform team team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jonathansoufer @georgewrmarshall @Cal-L @brianacnguyen @gauthierpetetin @metamaskbot