Skip to content

fix: fix nfts displayed on account and refactor collectibles component#9206

Merged
sethkfman merged 6 commits intomainfrom
fix/nfts-displayed-on-wrong-account
Apr 11, 2024
Merged

fix: fix nfts displayed on account and refactor collectibles component#9206
sethkfman merged 6 commits intomainfrom
fix/nfts-displayed-on-wrong-account

Conversation

@sahar-fehri
Copy link
Copy Markdown
Contributor

@sahar-fehri sahar-fehri commented Apr 11, 2024

Description

This PR fixes this issue #9196.
Patch created considering this open PR on core MetaMask/core#4143

When a user imports an account with Nfts then switches back and forth betwen two accounts, at some point he will see nfts from one account appear on another.

Link to core branch for the patch : https://github.com/MetaMask/core/compare/patch/mobile-assets-controllers-v-12-0-0...patch/mobile-assets-controllers-v-12-0-0-nft-bug?expand=1

Related issues

Fixes: #9196.
Core PR: MetaMask/core#4143

Manual testing steps

  1. Open app
  2. Import an account that has nfts (use for example orangefox.eth)
  3. Create a new account (You can either create a new account which will be empty or use any account that you already have)
  4. Switch back and forth between orangefox.eth and another account fast and you will see nfts from orangefox.eth that appear on the other account. (This should not happen on this PR)

Screenshots/Recordings

Before

Screen.Recording.2024-04-11.at.17.23.06.mov

After

Switching back and forth between accounts

Screen.Recording.2024-04-11.at.17.29.56.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team April 11, 2024 15:31
@sahar-fehri sahar-fehri requested a review from a team as a code owner April 11, 2024 15:31
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the team-mobile-ux Mobile UX team label Apr 11, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cf447a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc980f77-c265-4d20-8fde-301160e3648c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini
Copy link
Copy Markdown
Contributor

Also, can you update this core branch with these changes to run the script from it?
patch/mobile-assets-controllers-v-12-0-0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5894b6b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cda9b768-b17b-4db4-8ef8-8bc78cab3811

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

@sethkfman sethkfman dismissed tommasini’s stale review April 11, 2024 20:04

Has been addressed and needed to merged in.

@sethkfman sethkfman merged commit cbc67f5 into main Apr 11, 2024
@sethkfman sethkfman deleted the fix/nfts-displayed-on-wrong-account branch April 11, 2024 20:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NFTs owned by imported account is shown on wallet first account after importing

5 participants