Skip to content

feat: translate symbol warning text#9165

Merged
salimtb merged 1 commit intomainfrom
translate-add-missing-symbol-warning
Apr 8, 2024
Merged

feat: translate symbol warning text#9165
salimtb merged 1 commit intomainfrom
translate-add-missing-symbol-warning

Conversation

@salimtb
Copy link
Copy Markdown
Contributor

@salimtb salimtb commented Apr 8, 2024

Description

translation PR for warning ticker

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added the area-translation For Blendin translation. label Apr 8, 2024
@salimtb salimtb requested a review from a team as a code owner April 8, 2024 15:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Apr 8, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 8, 2024
@salimtb salimtb merged commit 3ec5422 into main Apr 8, 2024
@salimtb salimtb deleted the translate-add-missing-symbol-warning branch April 8, 2024 16:24
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 8, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-translation For Blendin translation. needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-assets

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants