Skip to content

test: Refactor Tab bar page object#9146

Merged
cortisiko merged 3 commits intomainfrom
detox/refactor-tabbar-component-page-object
Apr 5, 2024
Merged

test: Refactor Tab bar page object#9146
cortisiko merged 3 commits intomainfrom
detox/refactor-tabbar-component-page-object

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented Apr 4, 2024

Description

The purpose here is to refactor the objects in the tabBar page

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Mobile Platform team Run Smoke E2E labels Apr 4, 2024
@cortisiko cortisiko self-assigned this Apr 4, 2024
@cortisiko cortisiko requested a review from a team as a code owner April 4, 2024 18:34
@cortisiko cortisiko requested a review from a team April 4, 2024 18:34
@cortisiko cortisiko requested a review from a team as a code owner April 4, 2024 18:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 81b6c47
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f4f98c4c-42b7-45fb-96b1-5bd78d172686

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

SamuelSalas
SamuelSalas approved these changes Apr 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tommasini
tommasini approved these changes Apr 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cortisiko cortisiko merged commit 1c1c9ed into main Apr 5, 2024
@cortisiko cortisiko deleted the detox/refactor-tabbar-component-page-object branch April 5, 2024 11:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 5, 2024
@metamaskbot metamaskbot added the release-7.21.0 Issue or pull request that will be included in release 7.21.0 label Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

+1 more reviewer

@SamuelSalas SamuelSalas SamuelSalas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cortisiko cortisiko

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.21.0 Issue or pull request that will be included in release 7.21.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cortisiko @SamuelSalas @tommasini @gauthierpetetin @metamaskbot @sethkfman